Open
Conversation
qian-chu
reviewed
Jun 25, 2025
|
|
||
| permissions: | ||
| contents: read | ||
| on: push |
Collaborator
There was a problem hiding this comment.
Maybe I'm unaware of some hidden condition, but doesn't this mean the workflows run on each push (incl. publishing to PyPI?)
Collaborator
Author
There was a problem hiding this comment.
Not quite, cause just below for the Pypi part, you have this:
publish-to-pypi:
name: >-
Publish Python 🐍 distribution 📦 to PyPI
if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes
So the workflow runs on push, checks if the push has a tag and only then does the pypi release
Collaborator
|
Currently requesting to replace the PyPI project PyNeon. Will implement the workflow after we hear back from them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the publishing workflow to index the package on pypi. With the current implementation, publishing occurs as follows:
For the workflow to work, make sure to create an account with pypi and testpypi. Once you have done so, setup the TrustedPublishing thingy on both pypi and testpypi.
Make sure to enter the same name as your package name from your project.toml file under PyPI Project Name. Don't change anything to Environment Name.
Once you have followed these steps, the actions should execute without any issues. Maybe we can then decide to remove the publishing to testpypi for each push